Implement API method resize_disk for managed disks

[vicwicker]

Checklist:

Please check each of the boxes below for which you have completed the corresponding task:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added tests that prove my fix is effective or that my feature works
• All unit tests pass locally (after my changes)
• Rubocop reports zero offenses (after my changes)

Unit Test output:

Finished in 12.4 seconds (files took 1.2 seconds to load)
1020 examples, 0 failures

Coverage report generated for RSpec to /root/workspace/bosh-azure-cpi-release/src/bosh_azure_cpi/coverage. 4277 / 4296 LOC (99.56%) covered.
~/workspace/bosh-azure-cpi-release/src/bosh_azure_cpi

Rubocop output:

Offenses:

lib/cloud/azure/restapi/azure_client.rb:25:3: C: Metrics/ClassLength: Class has too many lines. [1664/1645]
  class AzureClient ...
  ^^^^^^^^^^^^^^^^^
spec/unit/azure_client/get_operation_spec.rb:8:1: C: Metrics/BlockLength: Block has too many lines. [2219/2197]
describe Bosh::AzureCloud::AzureClient do ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

187 files inspected, 2 offenses detected

Changelog

• This change allows to resize managed disks on Azure.
• Downsizing is not supported by Azure so in this case we still fall back to the strategy of creating a new disk and copying data.
• Analogous change to: cloudfoundry/bosh-aws-cpi-release@91a701e and cloudfoundry/bosh-openstack-cpi-release@d081938

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Victor Herrero Otal (6a95fbf, c543972)

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Victor Herrero Otal (6a95fbf)

[beyhan]

@vicwicker can you please sign the CLA?

[lnguyen]

Looks good overall, it might be hard to test but can you write some integration tests? If anything if it fails in pipelines we(BOSH team) will fix it

[vicwicker]

Looks good overall, it might be hard to test but can you write some integration tests? If anything if it fails in pipelines we(BOSH team) will fix it

@lnguyen I added a integration test: 5a70b1a

Other behaviours raise a Bosh::Clouds::NotSupported exception and I think that's covered by the unit tests and would become redundant with an integration test.

The summary of the new integration test is:

# bundle exec rspec spec/integration/managed_disks_spec.rb --format documentation
...
I, [2022-02-17T08:41:27.191922 #365 #5520] INFO --: Create new managed disk with 10000 MiB
...
I, [2022-02-17T08:41:33.215034 #365 #5520] INFO --: Resize managed disk 'caching:None;disk_name:bosh-disk-data-eb3f7caf-088e-4d0e-b8ad-922d458cf26d;resource_group_name:<redacted>' to 20000 MiB
... 
I, [2022-02-17T08:41:39.270051 #365 #5520] INFO --: Delete managed disk 'caching:None;disk_name:bosh-disk-data-eb3f7caf-088e-4d0e-b8ad-922d458cf26d;resource_group_name:<redacted>'
...
Finished in 20.23 seconds (files took 0.45375 seconds to load)
1 example, 0 failures

[beyhan]

In cloudfoundry/bosh-aws-cpi-release#123 we had some findings in the AWS CPI resize implementation which could be useful here. Just adding it as context.

[lnguyen]

LGTM

[vicwicker]

Is there anything left to do here or could we maybe merge this? Thanks!

[beyhan]

There is still one review open. We have a police to have two reviews per pr.

[jpalermo]

Sorry for the delay. Looks great. Thanks!