Remove config disk support #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally added in response to issue #472, which doesn't have a lot of details, but does mention Virtual Machine Scale Sets. This doesn't seem to be a fully implemented feature and there is no recent progress on making a real feature. The config disk code is current breaking due to new api changes introduce as part of PR #674 Rather than fix those failures, it makes more sense to remove an unused feature.
ramonskie
approved these changes
Dec 6, 2022
There was a problem hiding this comment.
LGTM
i think we can merge it if @andyliuliming does not respond within the next week
rkoster
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally added in response to issue #472, which doesn't have a lot of details, but does mention Virtual Machine Scale Sets. This doesn't seem to be a fully implemented feature and there is no recent progress on making a real feature.
The config disk code is current breaking due to new api changes introduce as part of PR #674 Rather than fix those failures, it makes more sense to remove an unused feature.