Update azure compute api version #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: * Should make the CPI work correctly in the China, German, and US Government regions. * Moves the API versions out to a common place to avoid future regional API version mismatch. * Updates documentation in comments to point to now-currently-used API versions. * Removes documentation in comments that didn't seem to point to anything relevant. A previous commit updated the Compute API version for the "Generic" region to account for changes made in a merge PR. However, the API version was not updated in the other regions. This caused failures for a customer operating in the China region, and will likely cause failures in the US Government and German regions. To avoid this problem in the future, we've moved out the duplicated data into a single place. Signed-off-by: Aram Price <pricear@vmware.com>
This commit moves the Azure Stack block of configuration to the bottom of the hash so that the code is a bit easier to think about. Signed-off-by: Kenneth Lakin <klakin@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Please check each of the boxes below for which you have completed the corresponding task:
Changelog
v42.0.0PR Notes
See the commit messages for more information about this PR.