Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert fastjsonparser #703

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

fmoehler
Copy link
Contributor

Checklist:

Please check each of the boxes below for which you have completed the corresponding task:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • All unit tests pass locally (after my changes)
  • Rubocop reports zero errors (after my changes)

Please include below the summary portions of the output from the following 2 scripts:

pushd src/bosh_azure_cpi
  bundle install
  bundle exec rake spec:unit
  bundle exec rake rubocop
popd

NOTE: Please see how to setup dev environment and run unit tests in docs/development.md.

Unit Test output:

1034 examples, 0 failures

Rubocop output:

190 files inspected, 50 offenses detected, 28 offenses autocorrectable

--> not related to these changes

Changelog

@fmoehler fmoehler mentioned this pull request Nov 13, 2024
9 tasks
@jpalermo jpalermo requested review from mvach, a team and anshrupani and removed request for a team November 14, 2024 15:54
@jpalermo
Copy link
Member

@mvach since you created the original fastjsonparser PR could you take a look at this. Rolling this back is most likely to affect the large environments you all work with.

@fmoehler
Copy link
Contributor Author

@jpalermo unfortunately @mvach is currently OOO.

We discussed internally and checked also why it was implemented back then. We concluded that it can be removed as the issue we had (timeout due to too long deployment time) was mitigated meanwhile by having smaller deployment sizes.

Furthermore, the fastjsonparser seems to be not maintained anymore, as there was no new version for two years and issues also remain in status "Open".

Copy link

@a-hassanin a-hassanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed it internally. Reverting due to the issue: anilmaurya/fast_jsonparser#25

We are still keeping an eye on performance here and if needed use something better for JSON parsing.

@jpalermo jpalermo merged commit d19237b into cloudfoundry:master Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants