Remove registry related code from the cli #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nouseforaname
force-pushed
the
feature/176871612-remove-registry-new
branch
from
3f3d92d to
93ced3f
Compare
rkoster
requested review from
a team,
jpalermo and
beyhan
and removed request for
a team
beyhan
reviewed
Feb 23, 2022
There was a problem hiding this comment.
It looks good. I think that I found one left over where we could rename the registry word or just remove it. It is:
bosh-cli/integration/create_env_test.go
Line 97 in 0e51615
|
@nouseforaname could you take a look at the changes requested by @beyhan? |
This PR is the counterpart to removing the Registry from bosh in: cloudfoundry/bosh@2ba78ed Remove Registry Code Regenerate Mocks fix minor issues in bin/mockgen (only runs with bsd sed) and remove registry line from it [#181129158]Remove registry behaviors from the BOSH CLI Signed-off-by: Ruben Koster <rubenk@vmware.com>
nouseforaname
force-pushed
the
feature/176871612-remove-registry-new
branch
from
93ced3f to
ba0f856
Compare
Thanks & done. |
beyhan
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the counterpart to removing the Registry from bosh in:
cloudfoundry/bosh@2ba78ed
Remove Registry Code
Regenerate Mocks
fix minor issues in bin/mockgen (only runs with bsd sed) and remove registry line from it