Auto-release CLI on new version of golang #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds task to the `automatically-release-new-patch` job that compares the golang version of the previously released BOSH CLI binary with the golang version of what would be released. If they're different (in the case of a bumped golang version, or intentional roll back), then an automatic release would be triggered, similar to when CVE fixes are detected.
aramprice
approved these changes
Mar 15, 2024
rkoster
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds task to the
automatically-release-new-patchjob that compares the golang version of the previously released BOSH CLI binary with the golang version of what would be released. If they're different (in the case of a bumped golang version, or intentional roll back), then an automatic release would be triggered, similar to when CVE fixes are detected.Additional Context
I noticed that we haven't released a version of the
boshCLI compiled usinggolang 1.22.1. Many BOSH-related repos have automatic releasing of patches when a golang bump occurs, the intention is to make the CLI consistent with those.This utilizes a new shared task I just added to the golang-release: cloudfoundry/bosh-package-golang-release@7360ed8
A test run of the task (minus the
successclause that causes a release) can be seen here: https://bosh.ci.cloudfoundry.org/teams/main/pipelines/bosh-cli/jobs/automatically-release-new-patch/builds/14