-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW PROVIDER] Support to deploy bosh on Alibaba Cloud #175
Conversation
Hey xiaozhu36! Thanks for submitting this pull request! All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate). When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization. If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions. Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look. |
value: | ||
availability_zone: ((zone)) | ||
instance_type: "ecs.mn4.small" | ||
instance_name: "bosh-director" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need instance_name
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It just a name for marking or classifying ECS instance. It is optional.
instance_type: "ecs.mn4.small" | ||
instance_name: "bosh-director" | ||
ephemeral_disk: {size: "51_200", category: "cloud_efficiency"} | ||
system_disk: {size: "51_200", category: "cloud_efficiency"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we default categories to cloud_efficiency
in the cpi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CPI sets a default 'cloud_efficiency' for disk category.
value: | ||
vswitch_id: ((vswitch_id)) | ||
security_group_ids: [((security_group_id))] | ||
internet_charge_type: "PayByTraffic" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can internet_charge_type
also be defaulted in the cpi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CPI does not set default for internet_charge_type
, but Alicloud API set a default 'PayByTraffic'.
alicloud/cpi.yml
Outdated
value: | ||
name: bosh-alicloud-cpi | ||
version: 16 | ||
url: http://bosh-((region)).oss-((region)).aliyuncs.com/bosh-alicloud-cpi-release-r16.tgz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wanted to add to bosh.io releases but found out that https://github.com/cloudfoundry-incubator/bosh-alicloud-cpi-release cannot be built with bosh create-release releases/bosh-alicloud-cpi/bosh-alicloud-cpi-16.yml
. will send credentials to you for the s3 bucket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cppforlife Thanks for your feedback and looking forward to your credentials.
Hey xiaozhu36! Thanks for submitting this pull request! All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate). When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization. If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions. Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look. |
Hey xiaozhu36! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
0ae1fb6
to
6268836
Compare
bb47fde
to
0157ac2
Compare
2e8a427
to
f63c091
Compare
74307d0
to
1bfad34
Compare
63425a5
to
5a4b70c
Compare
any update on this? Would really looking forward to have the new provider available via bosh-deployment |
9756ea4
to
dc454f6
Compare
887b759
to
8e58ecd
Compare
Closing and reopening to create a Pivotal Tracker story for prioritization |
✅ Hey xiaozhu36! The commit authors and yourself have already signed the CLA. |
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/167763364 The labels on this github issue will be updated when the story is started. |
Hi @xiaozhu36, We'd like to wait for alicloud stemcells to be available on bohs.io before merging this PR so that the stemcell references can be updated accordingly. Some other things:
Let us know if you have any questions, |
HI @jfmyers9 Thanks for your feedback. Waiting for good new from stemcell on bosh.io. About other things, my answer as following:
|
Hi @xiaozhu36, I'm going to merge this PR as is. For the two questions above:
Best, |
HI @jfmyers9 Thanks a lot for your reply and merge. About release blobstore, I have a question. I have set the remote blobs in the config/final.yml according to the release-blobstore docs, but when I run
My config/final.yml as follows:
My config/private.yml as follows:
I guess bosh will use the s3cli to upload the blobs , but I can not know how to config it. Do I need to deploy a bosh-director in my local? Can you give me ideas? |
This PR can help user to deploy bosh on Alibaba Cloud.
At present, CPI release and bosh stemcell are stored in Alicloud OSS service and we will change these to official address after them is accepted by bosh official.