Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW PROVIDER] Support to deploy bosh on Alibaba Cloud #175

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

xiaozhu36
Copy link
Contributor

This PR can help user to deploy bosh on Alibaba Cloud.

At present, CPI release and bosh stemcell are stored in Alicloud OSS service and we will change these to official address after them is accepted by bosh official.

@cfdreddbot
Copy link

Hey xiaozhu36!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

value:
availability_zone: ((zone))
instance_type: "ecs.mn4.small"
instance_name: "bosh-director"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need instance_name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just a name for marking or classifying ECS instance. It is optional.

instance_type: "ecs.mn4.small"
instance_name: "bosh-director"
ephemeral_disk: {size: "51_200", category: "cloud_efficiency"}
system_disk: {size: "51_200", category: "cloud_efficiency"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we default categories to cloud_efficiency in the cpi?

Copy link
Contributor Author

@xiaozhu36 xiaozhu36 Jan 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CPI sets a default 'cloud_efficiency' for disk category.

value:
vswitch_id: ((vswitch_id))
security_group_ids: [((security_group_id))]
internet_charge_type: "PayByTraffic"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can internet_charge_type also be defaulted in the cpi?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CPI does not set default for internet_charge_type , but Alicloud API set a default 'PayByTraffic'.

alicloud/cpi.yml Outdated
value:
name: bosh-alicloud-cpi
version: 16
url: http://bosh-((region)).oss-((region)).aliyuncs.com/bosh-alicloud-cpi-release-r16.tgz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wanted to add to bosh.io releases but found out that https://github.com/cloudfoundry-incubator/bosh-alicloud-cpi-release cannot be built with bosh create-release releases/bosh-alicloud-cpi/bosh-alicloud-cpi-16.yml. will send credentials to you for the s3 bucket.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cppforlife Thanks for your feedback and looking forward to your credentials.

@xiaozhu36 xiaozhu36 closed this Jan 19, 2018
@xiaozhu36 xiaozhu36 reopened this Jan 19, 2018
@cfdreddbot
Copy link

Hey xiaozhu36!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

@cfdreddbot
Copy link

Hey xiaozhu36!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@xiaozhu36 xiaozhu36 force-pushed the master branch 3 times, most recently from 0ae1fb6 to 6268836 Compare February 8, 2018 01:39
@xiaozhu36 xiaozhu36 force-pushed the master branch 2 times, most recently from bb47fde to 0157ac2 Compare June 13, 2018 07:56
@xiaozhu36 xiaozhu36 force-pushed the master branch 2 times, most recently from 2e8a427 to f63c091 Compare July 31, 2018 02:27
@xiaozhu36 xiaozhu36 force-pushed the master branch 2 times, most recently from 74307d0 to 1bfad34 Compare August 9, 2018 07:26
@xiaozhu36 xiaozhu36 force-pushed the master branch 2 times, most recently from 63425a5 to 5a4b70c Compare October 19, 2018 01:49
@benjaminguttmann-avtq
Copy link
Contributor

any update on this? Would really looking forward to have the new provider available via bosh-deployment

@xiaozhu36 xiaozhu36 force-pushed the master branch 2 times, most recently from 9756ea4 to dc454f6 Compare March 16, 2019 02:12
@xiaozhu36 xiaozhu36 force-pushed the master branch 2 times, most recently from 887b759 to 8e58ecd Compare July 21, 2019 00:34
@jfmyers9 jfmyers9 changed the base branch from master to develop August 7, 2019 16:07
@mfine30
Copy link
Contributor

mfine30 commented Aug 7, 2019

Closing and reopening to create a Pivotal Tracker story for prioritization

@mfine30 mfine30 closed this Aug 7, 2019
@mfine30 mfine30 reopened this Aug 7, 2019
@cfdreddbot
Copy link

✅ Hey xiaozhu36! The commit authors and yourself have already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/167763364

The labels on this github issue will be updated when the story is started.

@jfmyers9
Copy link
Contributor

jfmyers9 commented Aug 7, 2019

Hi @xiaozhu36,

We'd like to wait for alicloud stemcells to be available on bohs.io before merging this PR so that the stemcell references can be updated accordingly.

Some other things:

  • Trusty is no longer supported in bosh-deployment. Can you remove the use-trusty.yml operations file?
  • It would be good to get https://github.com/cloudfoundry-incubator/bosh-alicloud-cpi-release on bosh.io. In order to do this, that release needs to be built successfully from the releases directory, i.e. bosh create-release releases/bosh-alicloud-cpi/bosh-alicloud-cpi-24.0.0.yml. Is there a historical reason why this release uses the local provider for its release blobs?
  • To some of the points above, if the default value is already provided by either the CPI or the IAAS, can we remove extraneous keys from the above files?

Let us know if you have any questions,

@jfmyers9

@xiaozhu36
Copy link
Contributor Author

HI @jfmyers9 Thanks for your feedback. Waiting for good new from stemcell on bosh.io. About other things, my answer as following:

  • use-trusty.yml has been removed.
  • I also want to upload blobs to remote, but in my local computer, the bosh can not do that and it always throws the error:
2019/08/08 15:50:22 Upload failed: NoSuchBucket: The specified bucket does not exist.
        status code: 404, request id: 5D4BD43E146326CD7D001B0E, host id: 
2019/08/08 15:50:23 Upload failed: NoSuchBucket: The specified bucket does not exist.
        status code: 404, request id: 5D4BD43FECD3FD110D7667FF, host id: 
2019/08/08 15:50:24 Upload failed: NoSuchBucket: The specified bucket does not exist.
        status code: 404, request id: 5D4BD43FBE2DF200F44D477F, host id: 
  • I am sorry and can not got the third point. What do you mean "remove extraneous keys from the above files"?

@jfmyers9
Copy link
Contributor

Hi @xiaozhu36,

I'm going to merge this PR as is. For the two questions above:

  • There is good documentation on how to configure your release blobstore which covers how to use a publicly accessible blobstore. Once you have configured a public blobstore, when you run bosh add-blob and then bosh upload-blobs it should record the metadata for these blobs in the bosh release directory. Other users will then be able to recreate the release using the publicly accessible blobs that you have uploaded.
  • This was a reference to comments on a previous review asking if keys in the alicloud operations files were necessary to be specified. If they already have a default value, then specifying them in the manifest is redundant. In those cases you can remove these keys from the operations files and let the default values take effect.

Best,

@jfmyers9

@jfmyers9 jfmyers9 merged commit 95fc1a8 into cloudfoundry:develop Aug 26, 2019
@xiaozhu36
Copy link
Contributor Author

xiaozhu36 commented Sep 4, 2019

HI @jfmyers9 Thanks a lot for your reply and merge. About release blobstore, I have a question. I have set the remote blobs in the config/final.yml according to the release-blobstore docs, but when I run bosh add-blob in my local, there is an error:

2019/08/08 15:50:22 Upload failed: NoSuchBucket: The specified bucket does not exist.
        status code: 404, request id: 5D4BD43E146326CD7D001B0E, host id: 
2019/08/08 15:50:23 Upload failed: NoSuchBucket: The specified bucket does not exist.
        status code: 404, request id: 5D4BD43FECD3FD110D7667FF, host id: 
2019/08/08 15:50:24 Upload failed: NoSuchBucket: The specified bucket does not exist.
        status code: 404, request id: 5D4BD43FBE2DF200F44D477F, host id: 

My config/final.yml as follows:

---
blobstore:
  provider: s3
  options:
    bucket_name: <My alibaba cloud oss bucket name>
    host: <My alibaba cloud oss bucket host>

My config/private.yml as follows:

---
blobstore:
  options:
    access_key_id: <access_key_id>
    secret_access_key: <secret_access_key>

I guess bosh will use the s3cli to upload the blobs , but I can not know how to config it. Do I need to deploy a bosh-director in my local? Can you give me ideas?
If I want to install the latest s3cli, how to associate with bosh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants