Fixes Network changes in VBox 7.x

[chombium]

The output of the VBoxManage list natnetworks CLI command was changed in VirtualBox v7.x. This change adjusts the parameter names and uses the --long format of the command's output so that the Enabled parameter is present.

The change is compatible with the older VirtualBox version and does not break the CPI.

Fixes #30

[wayneeseguin]

Hi, I would love to help test this out also. Are you able to make the blobs available?

[chombium]

Hi @wayneeseguin,

Thank you very much for the offered help. What OS are you using? We have tested the changes on Linux and we're currently refactoring the Mac OS creation of networks as it has drastically changed and some relatively bigger changes are needed.

I can build and upload the current state of the cpi release, if you want to test it on Linux or Windows. We still haven't tested anything on Windows and we don't have a clue what might be possibly wrong there.

[wayneeseguin]

My main workstation is Linux, and I have Windows and Mac (M1) laptops.
You can message me on CF slack under the same username.

[chombium]

Hi @wayneeseguin, sorry for the late reply. Here is a link to the latest version of the cpi package. Check the following comment for details on how to test. You will need to adjust the patht to the .tgz package in the cpi.yml file used the bosh create-env command.

Thank you for your patience and the offered help.

[wayneeseguin]

OK, I will try to test it on my windows and Mac boxes this weekend

[ZPascal]

Hi @wayneeseguin, I am working with Jovan on this issue. I assume that the tar archive does not contain the Mac version yet, since I just implemented it today and have not tested it.

[chombium]

I will build and upload the latest versiot tomorrow

[ZPascal]

Hi @wayneeseguin, I've modified the corresponding code base to fix the MAC OS X related issues. I've published the new tar archive here. Feel free to use it for your tests.

[wayneeseguin]

I have downloaded the updated one thanks Pascal!

[chombium]

We (me and @ZPascal) are done with the changes and the PR is ready for review. We have tested everything on Linux and MacOS. We are waiting for @wayneeseguin to test a bit more and we can merge it.

[ramonskie]

tested it with

• virtualbox 7 it works.
• virtualbox 6.1 it fails

[ZPascal]

Hi @ramonskie, have you performed the test on Mac or Linux?

[chombium]

@ramonskie Thanks for testing. I can confirm that it broken on VBox 6.1 on Linux(Ubuntu 20.04 in my case). I will do some tests and fix it this week.

The error doesn't say much, but it look similar to the initial one:

Deploying:
  Creating instance 'bosh/0':
    Creating VM:
      Creating vm with stemcell cid 'sc-07c91907-3a6e-4e19-539b-3fa054203ef8':
        CPI 'create_vm' method responded with error: CmdError{"type":"Bosh::Clouds::CloudError","message":"Creating VM with agent ID '{{37cd10ed-32cf-4689-58ed-24d7a689177f}}': Enabling networks: Expected to find network 'NatNetwork'","ok_to_retry":false}

[lnguyen]

This is great. Thank you @chombium

[chombium]

@ramonskie Can you please test again? I've fixed the problem and now the CPI works on Linux with VBox 6.1 and 7. You can download the package here.

[ramonskie]

just tested it on virtualbox 6.1 and 7.0 and it works now

[chombium]

We've done some tests on Windows as well and have seen that the bosh cli has a Go flag UseIsolatedEnv hardcoded which is not supported on Windows. @ZPascal has written some more details. Hence, I would say Windows is out of the question for this PR.

[ZPascal]

FYI @chombium I've also opened an follow up issue on BOSH CLI side, to further discuss the root cause.

[rkoster]

Thanks! @chombium & @ZPascal

[ZPascal]

@rkoster Can you please create a new release version?