Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adds LOGNAME/USER environment variables for VirtualBox version 7 #41

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix: Adds LOGNAME/USER environment variables for VirtualBox version 7 #41

merged 1 commit into from
Dec 19, 2024

Conversation

arcenik
Copy link
Contributor

@arcenik arcenik commented Nov 22, 2024

Fix for #39

Removes the WARNING: line that VBoxManager display on any command.

$ VBoxManage --version
WARNING: Environment variable LOGNAME or USER does not correspond to effective user id.
7.1.4r165100

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 22, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: arcenik / name: François Scala (3ef7857)

@arcenik
Copy link
Contributor Author

arcenik commented Nov 22, 2024

If you know an elegant way to replace "\n" by an OS dependent line separator ...

@rkoster rkoster requested review from a team, ramonskie and mingxiao and removed request for a team November 28, 2024 16:02
@ramonskie
Copy link
Contributor

i think its better to get to the root of the problem.
did you find anything else? or tried to set those variables?

related:
https://www.virtualbox.org//ticket/22060
hashicorp/packer-plugin-virtualbox#130

@arcenik arcenik force-pushed the fix-39-vbox-version7 branch from 96be57b to 3ef7857 Compare December 6, 2024 09:15
@arcenik
Copy link
Contributor Author

arcenik commented Dec 6, 2024

PR updated to set LOGNAME/USER environment variables instead of cleaning up output

ramonskie
ramonskie approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@ramonskie ramonskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arcenik arcenik changed the title fix: VirtualBox version 7 output warning before the data fix: Adds LOGNAME/USER environment variables for VirtualBox version 7 Dec 6, 2024
@rkoster rkoster merged commit 79acbc4 into cloudfoundry:master Dec 19, 2024
1 check passed
@rkoster
Copy link
Contributor

rkoster commented Dec 19, 2024

Thanks! @arcenik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramonskie ramonskie ramonskie approved these changes

@mingxiao mingxiao Awaiting requested review from mingxiao mingxiao was automatically assigned from cloudfoundry/wg-foundational-infrastructure-vm-deployment-lifecycle-bosh-approvers

Assignees
No one assigned
Labels
None yet
Projects
Foundational Infrastructure Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arcenik @ramonskie @rkoster