Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NM_CONTROLLED=no to Azure network script #1457

Closed

Conversation

gossion
Copy link

@gossion gossion commented Sep 28, 2016

Fixes the issue that Azure CentOS VM can't be created when it has multiple dynamic NICs.

@cfdreddbot
Copy link

Hey gossion!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@gossion
Copy link
Author

gossion commented Oct 19, 2016

Hi @cppforlife, can you help to merge this PR? it is for Azure multiple network interfaces.

@dpb587-pivotal
Copy link
Contributor

@ljfranklin, @cunnie: any reason we shouldn't be merging this?

@ljfranklin
Copy link
Contributor

@dpb587-pivotal at a quick glance, @cunnie doesn't think this would cause any issues. However, he hedged his bets by saying he "could be wrong" :)

@gossion
Copy link
Author

gossion commented Nov 23, 2016

Hi @ljfranklin and @cunnie, we found the issue on Azure and the fix is only on Azure. See more detail in link.

@AbelHu
Copy link
Contributor

AbelHu commented Dec 6, 2016

@gossion Could you update your PR for the conflicts?

@gossion gossion force-pushed the develop-azure-centos-network branch from 15259fc to faaa18e Compare December 6, 2016 03:17
@AbelHu
Copy link
Contributor

AbelHu commented Feb 22, 2017

@ljfranklin This will cause the VM cannot be provisioned successfully when multiple NICs are enabled on Azure. It will cause the BATs failure. Please see below logs. It is a block issue when we are enabling BATs against centos stemcell in Azure CPI pipeline.

Failures:

  1) network configuration when using manual networking deploys multiple manual networks
     Failure/Error: expect(bosh('deploy')).to succeed
     Bosh::Exec::Error:
       command 'bundle exec bosh --non-interactive -P 1 --config /tmp/bosh_config20170221-362-1h9q7to --user azureuser --password Binxia5537 deploy --no-redact 2>&1' failed with exit code 1
     # ./lib/bat/bosh_runner.rb:19:in `bosh'
     # ./lib/bat/bosh_helper.rb:14:in `bosh'
     # ./spec/system/network_configuration_spec.rb:79:in `block (3 levels) in <top (required)>'

Finished in 247 minutes 56 seconds (files took 0.21033 seconds to load)
82 examples, 1 failure, 1 pending

@ljfranklin
Copy link
Contributor

cc @zaksoup, new CPI team anchor

@dpb587-pivotal
Copy link
Contributor

Closing - stemcell-related code has moved to cloudfoundry/bosh-linux-stemcell-build. Feel free to fix the mentioned multiple NICs issue and submit a new pull request there when ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants