Rebuilds Postgres indexes on glibc version change #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: * Adds early fails to the Postgres 10 and Postgres 13 jobs if the Postgres 15 data directory is present. This omission seemed to be a clear oversight. * Adds code to detect glibc version changes and rebuild indexes on all Postgres databases if the running glibc is newer than 2.27, and has changed since the last time we rebuild the indexes. glibc version 2.28 introduced a major change to how it performs collation. Whenever any changes to collations are introduced, indexes on Postgres tables must be rebuilt in order to avoid problems which include successful insertion of rows that violate uniqueness constraints on some keys but not others. Postgres 15 and later includes code that detects and warns about this situation, but leaves correcting the issue up to the operator... so the updates in this commit are still required. Signed-off-by: Joseph Palermo <jpalermo@pivotal.io>
jpalermo
force-pushed
the
reindex-on-glibc-version-change
branch
from
4a71a68 to
78d6603
Compare
beyhan
requested review from
a team,
aramprice and
jpalermo
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
This commit:
glibc version 2.28 introduced a major change to how it performs collation. Whenever any changes to collations are introduced, indexes on Postgres tables must be rebuilt in order to avoid problems which include successful insertion of rows that violate uniqueness constraints on some keys but not others.
Postgres 15 and later includes code that detects and warns about this situation, but leaves correcting the issue up to the operator... so the updates in this commit are still required.
Please provide contextual information.
See: https://wiki.postgresql.org/wiki/Locale_data_changes
https://www.crunchydata.com/blog/glibc-collations-and-data-corruption
What tests have you run against this PR?
Manual testing for script correctness.
Does this PR introduce a breaking change?
No.