Fix Health Monitor email messages and TLS #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the EventMachine SMTP client was formatting the headers and body of emails sent by Health Monitor for us. When this was replaced with Net::SMTP, the headers and body were improperly formatted and thus emails were not delivered. Additionally, this restores the STARTTLS behavior to how it worked when we used EventMachine; setting hm.email.tls to true forces a STARTTLS session, while setting it to false does not attempt a STARTTLS session even if the server supports it. Signed-off-by: Aram Price <aram.price@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
Previously, the EventMachine SMTP client was formatting the headers and body of emails sent by Health Monitor for us. When this was replaced with Net::SMTP, the headers and body were improperly formatted and thus emails were not delivered.
Additionally, this restores the STARTTLS behavior to how it worked when we used EventMachine; setting hm.email.tls to true forces a STARTTLS session, while setting it to false does not attempt a STARTTLS session even if the server supports it.
What tests have you run against this PR?