Switch to using buildpacks.cloudfoundry.org bucket #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdimsdale
commented
Jul 15, 2024
robdimsdale
commented
Jul 15, 2024
| @@ -6,7 +6,6 @@ buildpack-packager-git-uri-public: https://github.com/cloudfoundry/buildpack-pac | |||
| buildpack-packager-git-uri: git@github.com:cloudfoundry/buildpack-packager.git | |||
| buildpack-release-candidates-bucket: buildpack-release-candidates | |||
| buildpackapplifecycle-git-branch: develop | |||
| buildpacks-binaries-s3-bucket: pivotal-buildpacks | |||
There was a problem hiding this comment.
This is removed because it was only used in one place (and hence inlined in that location), and I think the indirection is not helpful.
robdimsdale
force-pushed
the
change-deps-bucket
branch
from
d8994b3 to
7ce0274
Compare
- this is necessary for the CFF to take over the CDN that sits in front of this namespace. - there is a lot of specific nuance, but the summary is that the CDN must now point to a bucket that has the same name - this does not affect consumers because they were already downloading dependencies from the CDN under the buildpacks.cloudfoundry.org host
robdimsdale
force-pushed
the
change-deps-bucket
branch
from
7ce0274 to
508135d
Compare
arjun024
approved these changes
Jul 15, 2024
arjun024
added a commit
that referenced
this pull request
Aug 16, 2024
We are moving from the defunct bucket "pivotal-buildpacks" to "buildpacks.cloudfoundry.org" See e.g. cloudfoundry/dotnet-core-buildpack-release#3 Also see related change with dependencies for more context: #403
arjun024
added a commit
that referenced
this pull request
Aug 16, 2024
We are moving from the defunct bucket "pivotal-buildpacks" to "buildpacks.cloudfoundry.org" See e.g. cloudfoundry/dotnet-core-buildpack-release#3 Also see related change with dependencies for more context: #403
arjun024
added a commit
that referenced
this pull request
Aug 21, 2024
We are moving from the defunct bucket "pivotal-buildpacks" to "buildpacks.cloudfoundry.org" See e.g. cloudfoundry/dotnet-core-buildpack-release#3 Also see related change with dependencies for more context: #403 Also related: cloudfoundry/go-buildpack-release#3 etc.
ForestEckhardt
pushed a commit
that referenced
this pull request
Aug 23, 2024
We are moving from the defunct bucket "pivotal-buildpacks" to "buildpacks.cloudfoundry.org" See e.g. cloudfoundry/dotnet-core-buildpack-release#3 Also see related change with dependencies for more context: #403 Also related: cloudfoundry/go-buildpack-release#3 etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes have already been fly'd