Do not replace with OpenSSL_1_1_0g w building python #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continuation of #417. This was attempted when the brats tests kept failing with SSL errors for python < 3.10 ONLY on cflinuxfs3. See https://buildpacks.ci.cf-app.com/teams/main/pipelines/python-buildpack/jobs/specs-edge-integration-develop-cflinuxfs3/builds/174 The change in #417 fixed the brats test The original change seems to have been intended for cflinuxfs2 as seen from this story: https://www.pivotaltracker.com/n/projects/1042066/stories/158871862 (also cloudfoundry/binary-builder@78323c4 and cloudfoundry/binary-builder@ccff965#diff-2183fca5c37f210ec00d4741797bd856666332eff7d11b7e10aeefb5001f40cdR12) It looks like this replace_openssl magic also happens for nginx, but this PR doesn't deal with that.
robdimsdale
approved these changes
Nov 14, 2024
ForestEckhardt
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #417.
This was attempted when the brats tests kept failing with SSL errors for python < 3.10 ONLY on cflinuxfs3. See
https://buildpacks.ci.cf-app.com/teams/main/pipelines/python-buildpack/jobs/specs-edge-integration-develop-cflinuxfs3/builds/174. Should have been triggered by upstream change python/cpython#118109.
The change in #417 fixed the brats test
The original change seems to have been intended for cflinuxfs2 as seen from this story: https://www.pivotaltracker.com/n/projects/1042066/stories/158871862 (also
cloudfoundry/binary-builder@78323c4 and
cloudfoundry/binary-builder@ccff965#diff-2183fca5c37f210ec00d4741797bd856666332eff7d11b7e10aeefb5001f40cdR12)
It looks like this replace_openssl magic also happens for nginx, but this PR doesn't deal with that.