Add app_log_revision property #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
This new property enables app logs in the format APP/REV/<version>/PROC/WEB/<process>. We added this property to the following jobs: * cloud_controller_ng * cc_deployment_updater * cloud_controller_clock * cloud_controller_worker We believe cloud_controller_worker does not send desired_lrp actions to diego, however we were not completely sure so we added it just incase. Co-authored-by: Seth Boyles <seth.boyles@broadcom.com>
Samze
force-pushed
the
add_revision_version
branch
from
61675bd to
7be6911
Compare
philippthun
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new property enables app logs in the format APP/REV//PROC/WEB/.
We added this property to the following jobs:
We believe cloud_controller_worker does not send desired_lrp actions to diego, however we were not completely sure so we added it just incase.
This will be used for Canary Deployments to identify which logs come from with revision of the app
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite