Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified getOrganizationId() & getSpaceId() as per V3 #1174

Closed
wants to merge 1 commit into from
Closed

Modified getOrganizationId() & getSpaceId() as per V3 #1174

wants to merge 1 commit into from

Conversation

suyash-sap
Copy link
Contributor

getOrganizationId() & getSpaceId() as per V3

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 5, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@suyash-sap suyash-sap mentioned this pull request Jan 12, 2023
Open
@suyash-sap
Copy link
Contributor Author

Hello @dmikusa, @pivotal-david-osullivan Please review this Pull Request as a part of lacking v3 operations

@radoslav-tomov
Copy link
Contributor

@dmikusa Any chance we can get this merged ?

@anthonydahanne
Copy link
Contributor

Hello @dmikusa , @pivotal-david-osullivan
I believe it's OK to start using v3 API, without even branching or bumping the version main, since as @Gerg told me the other day:

The v2 API continues to exist, but it is not under active development and I expect it to rot over time.

This PR looks fine to me, but I don't have approval powers yet; please consider reviewing / approving
Thank you!

pivotal-david-osullivan added a commit that referenced this pull request Feb 12, 2024
@pivotal-david-osullivan
Merge pull request #1215 from anthonydahanne/bunch-of-prs-rebased
40fd854 
Migrate integration tests to Junit 5 and selectively apply changes from  #1174 and #1185
@anthonydahanne
Copy link
Contributor

anthonydahanne commented Feb 12, 2024 •
edited
Loading

was included and merged with this PR #1215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmikusa dmikusa Awaiting requested review from dmikusa

@pivotal-david-osullivan pivotal-david-osullivan Awaiting requested review from pivotal-david-osullivan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suyash-sap @radoslav-tomov @anthonydahanne @pivotal-david-osullivan