Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'cf a' should print out available information even if an app process was not found #2734

Closed
4 tasks done
stephanme opened this issue Jan 11, 2024 · 1 comment
Closed
4 tasks done

'cf a' should print out available information even if an app process was not found #2734

stephanme opened this issue Jan 11, 2024 · 1 comment
Labels
unscheduled

Comments

@stephanme
Copy link
Contributor

Please fill out the issue checklist below and provide ALL the requested information.

  • I reviewed open and closed github issues that may be related to my problem.
  • I tried updating to the latest version of the CF CLI to see if it fixed my problem.
  • I attempted to run the command with CF_TRACE=1 to help debug the issue.
  • I am reporting a bug that others will be able to reproduce.

Describe the bug and the command you saw an issue with

cf a in a space that contains ~800 apps takes ~5min (see also #2733 for one reason). When an app in the space is deleted e.g. by CI while cf a is running, cli fails and prints out nothing.

What happened

% cf a
Getting apps in org test / space test as stephan.merker@sap.com...

Process not found
FAILED

The 'process not found' error result most likely from GET /v3/processes/<process guid>/stats requests.

Expected behavior

cf a should print out available info for better UX, especially when it takes long time in large spaces:

% cf a
Getting apps in org test / space test as stephan.merker@sap.com...

name               requested state   processes                          routes
app1               started           web:1/1                            app1.cfapps.eu12.hana.ondemand.com
app2               started           not found
...

(when app2 got deleted during execution of cf a)

Since multiple CF API calls are involved in cf a, cli can't guarantee a consistent output.

Exact Steps To Reproduce

  • push several hundred apps in a space
  • run cf a
  • while cf a is running, delete one of the last apps (sorted by app name)

Provide more context

  • platform and shell details: Mac OS
  • version of the CLI you are running: 8.7.6+a659013.2023-12-14
  • version of the CC API Release you are on: 3.153.0

Notes regarding V6 and V7 CLI support:

  • V6:
    • Minimum supported version of CF Deployment: v7.0.0 (CAPI Release: 1.74.0 (APIs 2.128.0 and 3.63.0))
    • Maximum supported version of CF Deployment: v13.4.0 (CAPI Release: 1.94.0 (APIs 2.149.0 and 3.84.0))
  • V7:
    • Minimum supported version of CF Deployment: v13.5.0 (CAPI Release: 1.95.0 (APIs 2.150.0 and 3.85.0))
johha added a commit to sap-contributions/cli that referenced this issue Feb 16, 2024
@johha
Introduce --no-stats for cf apps
eef21f2 
Fetching process stats requires a `/stats` request for each process.
If a space contains many apps or processes this slows down `cf apps`.
If a user is not interested in stats the `--no-stats` flag can be helpful.

In addition the error handling was improved so that `ProcessNotFoundError` don't abort `cf apps`. Related to cloudfoundry#2734
johha added a commit to sap-contributions/cli that referenced this issue Feb 19, 2024
@johha
Introduce --no-stats for cf apps
0e7da17 
Fetching process stats requires a `/stats` request for each process.
If a space contains a large number apps or processes this slows down `cf apps`.
In case a user is not interested in stats the `--no-stats` flag can be helpful.

In addition the error handling was improved so that `ProcessNotFoundError` does not cause `cf apps` to fail. Related to cloudfoundry#2734
johha added a commit to sap-contributions/cli that referenced this issue Feb 19, 2024
@johha
Handle ProcessNotFoundError in cf apps
142a0d3 
As a user calls `cf apps` in a large space it might happen that a app
was deleted while the CLI is putting all the different information (processes, stats & routes) together.
This leads to a failing `cf apps` command.
This change prevents this by catching `ProcessNotFoundError` errors and returning `nil` instead.
Related to cloudfoundry#2734
@johha johha mentioned this issue Feb 19, 2024
Merged
3 tasks
johha added a commit to sap-contributions/cli that referenced this issue Feb 20, 2024
@johha
Handle ProcessNotFoundError in cf apps
7240bd3 
As a user calls `cf apps` in a large space it might happen that a app
was deleted while the CLI is putting all the different information (processes, stats & routes) together.
This leads to a failing `cf apps` command.
This change prevents this by catching `ProcessNotFoundError` errors and returning `nil` instead.
Related to cloudfoundry#2734
johha added a commit to sap-contributions/cli that referenced this issue Feb 20, 2024
@johha
Handle ProcessNotFoundError in cf apps
878578a 
As a user calls `cf apps` in a large space it might happen that a app
was deleted while the CLI is putting all the different information (processes, stats & routes) together.
This leads to a failing `cf apps` command.
This change prevents this by catching `ProcessNotFoundError` errors and returning `nil` instead.
Related to cloudfoundry#2734
johha added a commit to sap-contributions/cli that referenced this issue Feb 20, 2024
@johha
Handle ProcessNotFoundError in cf apps
2f0bce4 
As a user calls `cf apps` in a large space it might happen that a app
was deleted while the CLI is putting all the different information (processes, stats & routes) together.
This leads to a failing `cf apps` command.
This change prevents this by catching `ProcessNotFoundError` errors and returning `nil` instead.
Related to cloudfoundry#2734
a-b pushed a commit that referenced this issue Feb 22, 2024
@johha
Improve cf apps with --no-stats and better error handling (#2795)
0fc2173 
* Introduce `--no-stats` for `cf apps`

Fetching process stats requires a `/stats` request for each process.
If a space contains a large number apps or processes this slows down `cf apps`.
In case a user is not interested in stats the `--no-stats` flag can be helpful.

* Handle `ProcessNotFoundError` in `cf apps`

As a user calls `cf apps` in a large space it might happen that a app
was deleted while the CLI is putting all the different information (processes, stats & routes) together.
This leads to a failing `cf apps` command.
This change prevents this by catching `ProcessNotFoundError` errors and returning `nil` instead.
Related to #2734
a-b pushed a commit that referenced this issue Feb 22, 2024
@johha
Improve cf apps with --no-stats and better error handling [V8] (#…
5659779 
…2796)

* Introduce `--no-stats` for `cf apps`

Fetching process stats requires a `/stats` request for each process.
If a space contains a large number apps or processes this slows down `cf apps`.
In case a user is not interested in stats the `--no-stats` flag can be helpful.

* Handle `ProcessNotFoundError` in `cf apps`

As a user calls `cf apps` in a large space it might happen that a app
was deleted while the CLI is putting all the different information (processes, stats & routes) together.
This leads to a failing `cf apps` command.
This change prevents this by catching `ProcessNotFoundError` errors and returning `nil` instead.
Related to #2734
@johha
Copy link
Contributor

johha commented Mar 6, 2024

Fixed with #2795

@moleske moleske closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unscheduled
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stephanme @cf-gitbot @moleske @johha