Add experimental destination-protocol flag to map-route #2192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to specify HTTP2 protocol can be used to reach application.
Does this PR modify CLI v6 or v7?
V8
Description of the Change
Adding
--destination-protocol
flag to the map-route cli command. This will allow users to use HTTP2 protocol to communicate with their apps. It sets theprotocol
property in the map route destination in Cloud Controller which is passed to the Diego LRP and advertised to Gorouter. By default ifdestination-protocol
is not set HTTP1 protocol will be used for HTTP route. We extended the validation whenmap-route
is used for existing route: if everything is the same except for the destination protocol the error will be raised.This command is documented in
map-route
command help message as an experimental command. We have not decided yet how this will be displayed for users inroutes
or another command. So there is a possibility that this flag name might change in the future.Why Is This PR Valuable?
Users will be able to use CLI to activate HTTP2 protocol to access their applications.
Why Should This Be In Core?
This is a core functionality of the route destination.
Applicable Issues
#2188
cloudfoundry/routing-release#200
How Urgent Is The Change?
We want to include this in V8.
Other Relevant Parties
@ctlong @Gerg