feat: Add move-route command to cf cli #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shwetha Gururaj <gururajsh@vmware.com>
PeteLevineA
requested review from
a-b,
Gerg,
MerricdeLauney,
jdgonzaleza and
gururajsh
|
I may be behind the times, but I think we decided to change this command to |
Based on this conversation i believe you are correct |
Co-authored-by: Shwetha Gururaj <gururajsh@vmware.com>
PeteLevineA
changed the title
|
thanks @Gerg & @MerricdeLauney . @gururajsh and I updated to |
Co-authored-by: Shwetha Gururaj <gururajsh@vmware.com>
MerricdeLauney
approved these changes
Aug 15, 2022
gururajsh
added a commit
that referenced
this pull request
Aug 23, 2022
* feat: Add transfer-route-owner command to cf cli Co-authored-by: Shwetha Gururaj <gururajsh@vmware.com> * feat: update repository variable. Update workflow action * fix: remove windows 2016, swap to windows latest. Fix relative file path * chore: windows values * chore: swap to Rel instead of join * chore: main dir * chore: join on current dir * chore: clean path first * chore: try from slash * chore: remove dot syntax * chore: swap to move-route Co-authored-by: Shwetha Gururaj <gururajsh@vmware.com> * chore: windows tests again * chore: remove test println * chore: update path to /relationships/space from transferowner Co-authored-by: Shwetha Gururaj <gururajsh@vmware.com> * Change display text * Remove focus * Fix typo * Send non-array data in requestBody * Change message ordering * Create shared domain instead of private Co-authored-by: Shwetha Gururaj <gururajsh@vmware.com>
a-b
reviewed
Aug 23, 2022
| @@ -12,7 +12,7 @@ jobs: | |||
| analyze: | |||
| name: Analyze | |||
| runs-on: ubuntu-latest | |||
| if: ${{ github.action_repository == 'cloudfoundry/cli' }} | |||
| if: ${{ github.repository == 'cloudfoundry/cli' }} | |||
There was a problem hiding this comment.
I'd prefer having GitHub Actions related changes in a separate PR, so we can easily synchronize these changes with other branches.
a-b
reviewed
Aug 23, 2022
| @@ -83,9 +79,8 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: | |||
| - windows-2022 | |||
| - windows-latest | |||
gururajsh
added a commit
that referenced
this pull request
Aug 24, 2022
* feat: Add transfer-route-owner command to cf cli Co-authored-by: Shwetha Gururaj <gururajsh@vmware.com> * feat: update repository variable. Update workflow action * fix: remove windows 2016, swap to windows latest. Fix relative file path * chore: windows values * chore: swap to Rel instead of join * chore: main dir * chore: join on current dir * chore: clean path first * chore: try from slash * chore: remove dot syntax * chore: swap to move-route Co-authored-by: Shwetha Gururaj <gururajsh@vmware.com> * chore: windows tests again * chore: remove test println * chore: update path to /relationships/space from transferowner Co-authored-by: Shwetha Gururaj <gururajsh@vmware.com> * Change display text * Remove focus * Fix typo * Send non-array data in requestBody * Change message ordering * Create shared domain instead of private Co-authored-by: Shwetha Gururaj <gururajsh@vmware.com> Co-authored-by: Peter Levine <pete@ionisix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Shwetha Gururaj gururajsh@vmware.com
This is an intro PR for the upcoming changes made by the platform interfaces team. This PR will not be merged until sign off and successful run of integration test below once we have an environment with cf-api:edge.
Does this PR modify CLI v6, CLI v7, or CLI v8?
v8
Description of the Change
Adding the
cf transfer-route-ownercommand to the cf cliWhy Is This PR Valuable?
When users share a route, ownership is maintained by the originating space. This new command allows transfer of ownership.
Why Should This Be In Core?
This command is needed when a route is shared and needs to be deleted or modified by the target space.
Applicable Issues
List any applicable Github Issues here
How Urgent Is The Change?
Not urgent, still working with the Platform Interface team on definition.
Other Relevant Parties
CF API transfer route owner endpoint is required