Add User-agent for repo-plugins api calls #2722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- would be nice to use command.config but we couldn't see an easy way to thread it Co-authored-by: david alvarado <alvaradoda@vmware.com>
…o as we made changes
moleske
added a commit
that referenced
this pull request
Jan 9, 2024
* Add user agent info for plugin api calls * Remove comment * Edit error message * Use same user agent as api/plugin/client.go - would be nice to use command.config but we couldn't see an easy way to thread it Co-authored-by: david alvarado <alvaradoda@vmware.com> * Add test - The reason it is checking NotTo(Equal(...)) is because the default user agent "Go-http-client/1.1" is being blocked by the webserver Co-authored-by: david alvarado <alvaradoda@vmware.com> * Clean up deprecation and some warnings and regenerate fake_plugin_repo as we made changes --------- Co-authored-by: M. Oleske <moleske@pivotal.io> Co-authored-by: david alvarado <alvaradoda@vmware.com> Co-authored-by: Al Berez <a-b@users.noreply.github.com>
3 tasks
moleske
added a commit
that referenced
this pull request
Jan 9, 2024
* Add user agent info for plugin api calls * Remove comment * Edit error message * Use same user agent as api/plugin/client.go - would be nice to use command.config but we couldn't see an easy way to thread it Co-authored-by: david alvarado <alvaradoda@vmware.com> * Add test - The reason it is checking NotTo(Equal(...)) is because the default user agent "Go-http-client/1.1" is being blocked by the webserver Co-authored-by: david alvarado <alvaradoda@vmware.com> * Clean up deprecation and some warnings and regenerate fake_plugin_repo as we made changes --------- Co-authored-by: M. Oleske <moleske@pivotal.io> Co-authored-by: david alvarado <alvaradoda@vmware.com> Co-authored-by: Al Berez <a-b@users.noreply.github.com>
This was referenced Jan 9, 2024
moleske
added a commit
that referenced
this pull request
Jan 16, 2024
* Add user agent info for plugin api calls * Remove comment * Edit error message * Use same user agent as api/plugin/client.go - would be nice to use command.config but we couldn't see an easy way to thread it * Add test - The reason it is checking NotTo(Equal(...)) is because the default user agent "Go-http-client/1.1" is being blocked by the webserver * Clean up deprecation and some warnings and regenerate fake_plugin_repo as we made changes --------- Co-authored-by: Shwetha Gururaj <gururajsh@vmware.com> Co-authored-by: david alvarado <alvaradoda@vmware.com> Co-authored-by: Al Berez <a-b@users.noreply.github.com>
moleske
added a commit
that referenced
this pull request
Jan 16, 2024
* Add user agent info for plugin api calls * Remove comment * Edit error message * Use same user agent as api/plugin/client.go - would be nice to use command.config but we couldn't see an easy way to thread it * Add test - The reason it is checking NotTo(Equal(...)) is because the default user agent "Go-http-client/1.1" is being blocked by the webserver * Clean up deprecation and some warnings and regenerate fake_plugin_repo as we made changes --------- Co-authored-by: Shwetha Gururaj <gururajsh@vmware.com> Co-authored-by: david alvarado <alvaradoda@vmware.com> Co-authored-by: Al Berez <a-b@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where this PR should be backported?
Description of the Change
cf repo-pluginscommand is erroring withLogged errors: Invalid json data from 'CF-Community' - invalid character '<' looking for beginning of value. It seems https://plugins.cloudfoundry.org/list endpoint is expecting a user agent to be set. This PR adds that.Why Is This PR Valuable?
Fixes a bug.
Applicable Issues
List any applicable GitHub Issues here
How Urgent Is The Change?
Is the change urgent? If so, explain why it is time-sensitive.
Other Relevant Parties
Who else is affected by the change?