V8 add redact option for env block when pushing an app with a manifest.yml #2787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#186767925] IF the app is pushed with a manifest AND the app needs secrets set via environment variables THEN currently there is no way to avoid leaking secrets in the output of cf push commands. technically this could be avoided by not using a manifest and running: ```cf push --no-start cf set-env ... cf set-env ... cf set-env ... ... ` but that escalates quickly if the APP contains many secret things in it's env requirements. We face this in an errand where: - the bosh release renders the application.yml - the application.yml contains secrets in the env block - the errand VM streams it's logs to a logging server This can be remediated by the suggested redacttion. `--redact-env` to indiscriminately change all values to `<redacted>` if they're contained within an apps `env` block.
[#186767925] IF the app is pushed with a manifest AND the app needs secrets set via environment variables THEN currently there is no way to avoid leaking secrets in the output of cf push commands. technically this could be avoided by not using a manifest and running: ```cf push --no-start cf set-env ... cf set-env ... cf set-env ... ... ` but that escalates quickly if the APP contains many secret things in it's env requirements. We face this in an errand where: - the bosh release renders the application.yml - the application.yml contains secrets in the env block - the errand VM streams it's logs to a logging server This can be remediated by the suggested redacttion. `--redact-env` to indiscriminately change all values to `<redacted>` if they're contained within an apps `env` block.
[#186767925]
|
as #2763 was approved and merged, merging this for v8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 PR for
#2763