Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8: Update ginkgo version to v2 #2809

Merged
merged 10 commits into from
Mar 22, 2024
Merged

v8: Update ginkgo version to v2 #2809

merged 10 commits into from
Mar 22, 2024

Conversation

gururajsh
Copy link
Member

@gururajsh gururajsh commented Mar 7, 2024

Thank you for contributing to the CF CLI! Please read the following:

  • Please make sure you have implemented changes in line with the contributing guidelines
  • We're not allowed to accept any PRs without a signed CLA, no matter how small.
    If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
  • All new code requires tests to protect against regressions.
  • Contributions must be made against the appropriate branch. See the contributing guidelines
  • Contributions must conform to our style guide. Please reach out to us if you have questions.

Where this PR should be backported?

  • main - all changes should by default start here
  • v8
  • v7

Description of the Change

CLI was using ginkgo version v1 which is outdated for a while now. This change updates the ginkgo version to v2.

Why Is This PR Valuable?

Updates the ginkgo version so that there is on going support for this dependency.

Applicable Issues

None

How Urgent Is The Change?

Not urgent

Other Relevant Parties

None

gururajsh and others added 7 commits March 5, 2024 14:26
* Add user agent info for plugin api calls
- Newer lager was needed with newer diego-ssh
* Replace depracted ginkgo calls with non deprecated calls
* Remove ACK_GINKGO_RC
* Desperate attempt at resolving output issue by using serial decorator and using non deprecated pty
* Turn off  Gingkno v2 parallel mode
* Adjust integration tests to use ginkgo v2
* Add Byte to lograte, disk and memory regexes used by int tests
---------

Co-authored-by: M. Oleske <moleske@pivotal.io>
Co-authored-by: Al Berez <al.berez@broadcom.com>
Co-authored-by: Cristhian Peña <ccjaimes@users.noreply.github.com>
Co-authored-by: Marc Paquette <marc.paquette@broadcom.com>
@gururajsh gururajsh changed the title Update ginkgo version to v2 v8: Update ginkgo version to v2 Mar 7, 2024
Copy link
Member

@a-b a-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-b a-b merged commit 77bd035 into cloudfoundry:v8 Mar 22, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants