Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V8: Ginkgo v2 additional changes #2836

Merged
merged 10 commits into from
Mar 28, 2024
Merged

V8: Ginkgo v2 additional changes #2836

merged 10 commits into from
Mar 28, 2024

Commits on Mar 27, 2024

  1. Update CLI to use ginkgo v2 

    * Add user agent info for plugin api calls
- Newer lager was needed with newer diego-ssh
* Replace depracted ginkgo calls with non deprecated calls
* Remove ACK_GINKGO_RC
* Desperate attempt at resolving output issue by using serial decorator and using non deprecated pty
* Turn off  Gingkno v2 parallel mode
* Adjust integration tests to use ginkgo v2
* Add Byte to lograte, disk and memory regexes used by int tests
---------

Co-authored-by: M. Oleske <moleske@pivotal.io>
Co-authored-by: Al Berez <al.berez@broadcom.com>
Co-authored-by: Cristhian Peña <ccjaimes@users.noreply.github.com>
Co-authored-by: Marc Paquette <marc.paquette@broadcom.com>
    @gururajsh @moleske
    @a-b @ccjaimes @MarcPaquette
    5 people committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    53a5dbd View commit details
    Browse the repository at this point in the history

  2. run v8

    @gururajsh
    gururajsh committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    0c86f6c View commit details
    Browse the repository at this point in the history

  3. Fix syntax

    @gururajsh
    gururajsh committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    cf76230 View commit details
    Browse the repository at this point in the history

  4. Remove on workflow run

    @gururajsh
    gururajsh committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    05dfdc0 View commit details
    Browse the repository at this point in the history

  5. Remove PR Check

    @gururajsh
    gururajsh committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    d9e3188 View commit details
    Browse the repository at this point in the history

  6. Revert workflow changes

    @gururajsh
    gururajsh committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    268cf52 View commit details
    Browse the repository at this point in the history

  7. Update checks-action version

    @gururajsh
    gururajsh committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    1d8c33f View commit details
    Browse the repository at this point in the history

  8. Fix go.mod gomega 

    When we ran Ginkgo v2 tests for the first time we got the following
error:

```
  go install github.com/onsi/ginkgo/v2/ginkgo
  go install github.com/onsi/gomega/matchers
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
go: downloading github.com/onsi/ginkgo/v2 v2.15.0
go: downloading github.com/go-task/slim-sprig v0.0.0-20230315185526-52ccab3ef572
go: downloading golang.org/x/tools v0.17.0
go: downloading github.com/google/pprof v0.0.0-20230912144702-c363fe2c2ed8
missing go.sum entry for module providing package github.com/onsi/gomega/matchers; to add:
	go mod download github.com/onsi/gomega
Error: Process completed with exit code 1.
```
    @a-b @gururajsh
    a-b authored and gururajsh committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    ce31efa View commit details
    Browse the repository at this point in the history

  9. Ginkgo v2 additional changes (cloudfoundry#2832) 

    Update deprecated v1 calls to use v2
    @gururajsh
    gururajsh committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    8d663d2 View commit details
    Browse the repository at this point in the history

  10. fix dependencies

    @gururajsh
    gururajsh committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    2604816 View commit details
    Browse the repository at this point in the history