Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from repo secrets to vars [v8] #2841

Merged
merged 3 commits into from
May 8, 2024
Merged

Switch from repo secrets to vars [v8] #2841

merged 3 commits into from
May 8, 2024

Conversation

a-b
Copy link
Member

@a-b a-b commented Apr 4, 2024 •
edited

  • cleanup

Where this PR should be backported?

Description of the Change

Move non-secrets to vars

@a-b a-b requested a review from gururajsh April 4, 2024 07:39
gururajsh
gururajsh approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@gururajsh gururajsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gururajsh
Copy link
Member

Can we have PRs for main and v7 as well? This will help to maintain the consistency and we will not have to store both secrets and vars.

@a-b
Copy link
Member Author

a-b commented May 8, 2024

Can we have PRs for main and v7 as well? This will help to maintain the consistency and we will not have to store both secrets and vars.

This is covered by Where this PR should be backported? section in the description.

@a-b a-b changed the title Switch from repo secrets to vars Switch from repo secrets to vars [v8] May 8, 2024
@a-b a-b merged commit 74f1353 into v8 May 8, 2024
8 of 10 checks passed
@a-b a-b deleted the gha-switch-to-vars-v8 branch May 8, 2024 18:40
This was referenced May 8, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gururajsh gururajsh gururajsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@a-b @gururajsh