Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shepherd envs instead on toolsmiths for tests (v8) #2864

Merged
merged 12 commits into from
Apr 30, 2024

Conversation

gururajsh
Copy link
Member

Where this PR should be backported?

  • main - all changes should by default start here
  • v8
  • v7

Description of the Change

  • CLI integration tests used toolsmiths envs. This change is to use shepherd environments instead since toolsmiths envs are not longer supported.

  • Min Capi job is disabled until we figure out CLI versioning policy (how far back we want to support cf-deployment version).

Why Is This PR Valuable?

What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?

Applicable Issues

List any applicable GitHub Issues here

How Urgent Is The Change?

Its time-sensitive since we have not run tests/merge PRS/release CLI because of envs not being available.

Other Relevant Parties

Who else is affected by the change?

gururajsh and others added 12 commits April 26, 2024 13:52
* Add user agent info for plugin api calls
- Newer lager was needed with newer diego-ssh
* Replace depracted ginkgo calls with non deprecated calls
* Remove ACK_GINKGO_RC
* Desperate attempt at resolving output issue by using serial decorator and using non deprecated pty
* Turn off  Gingkno v2 parallel mode
* Adjust integration tests to use ginkgo v2
* Add Byte to lograte, disk and memory regexes used by int tests
---------

Co-authored-by: M. Oleske <moleske@pivotal.io>
Co-authored-by: Al Berez <al.berez@broadcom.com>
Co-authored-by: Cristhian Peña <ccjaimes@users.noreply.github.com>
Co-authored-by: Marc Paquette <marc.paquette@broadcom.com>
Use shepherd environments instead of toolsmiths to run integration tests. As part of this change, min capi job is disabled since we are still figuring out our versioning policy of how long CLI should support an old version of CAPI.
@gururajsh gururajsh requested a review from reedr3 April 29, 2024 21:28
Copy link
Contributor

@reedr3 reedr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gururajsh gururajsh merged commit fe13f57 into cloudfoundry:v8 Apr 30, 2024
10 of 13 checks passed
vchrisb pushed a commit to vchrisb/cli that referenced this pull request May 3, 2024
…2864)

Use shepherd environments instead of toolsmiths to run integration tests. As part of this change, min capi job is disabled since we are still figuring out our versioning policy of how long CLI should support an old version of CAPI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants