Add version check to CLAW update [v7] #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeteLevineA
approved these changes
May 13, 2024
moleske
approved these changes
May 23, 2024
a-b
reviewed
May 23, 2024
| @@ -1067,7 +1067,7 @@ jobs: | |||
| uses: actions/checkout@v4 | |||
| with: | |||
| repository: cloudfoundry/CLAW | |||
| ref: develop | |||
| ref: master | |||
| path: CLAW | |||
| ssh-key: ${{ secrets.GIT_SSH_KEY_CLAW }} | |||
There was a problem hiding this comment.
Is using (read/write) GITHUB_TOKEN to work with this repo possible in this case?
https://docs.github.com/en/actions/security-guides/automatic-token-authentication
https://dev.to/github/the-githubtoken-in-github-actions-how-it-works-change-permissions-customizations-3cgp#
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Before updating CLAW with new release version, make sure the new version is not already present in the list. If the new version already exists, then something has gone wrong with the release process, so it exits.
Why Is This PR Valuable?
Prevents duplicate entries to CLAW.
Applicable Issues
List any applicable GitHub Issues here
How Urgent Is The Change?
Is the change urgent? If so, explain why it is time-sensitive.
Other Relevant Parties
Who else is affected by the change?