Fix race condition in config handling (v8)

[f-blass]

Description of the Change

The CLI encounters race conditions when handling config files if multiple commands are executed in parallel.

Currently, the CLI writes a new config for every command executed due to the code in command_parser.go. However, it also deletes all temporary config files when reading the config, leading to race conditions between multiple processes. This PR introduces two changes to mitigate this problem:

1. Ignore "File Not Found" errors when attempting to delete a file. This change addresses the issue where multiple processes list and delete temporary files simultaneously.
2. Only delete temp config files older than 5 minutes. This change resolves the problem where one process creates a temporary config that it later wants to rename, while a second process deletes this temp config in the meantime. Orphan files should be rare, as they are normally pruned by the signal handler, as seen in

   cli/util/configv3/write_config.go

   Lines 63 to 66 in 04df8ae

   	func catchSignal(sig chan os.Signal, tempConfigFileName string) {
   	<-sig
   	_ = os.Remove(tempConfigFileName)
   	os.Exit(2)

Why Is This PR Valuable?

Enables usage of the CF CLI in scripts which execute commands in parallel

Applicable Issues

fixes #2232

How Urgent Is The Change?

Medium

Other Relevant Parties

Anyone using the CLI in scripts with parallel execution. Multiple users have encountered this issue, as discussed in #2232.

Related PRs

• v7
• main

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: gururajsh / name: Shwetha Gururaj (324e1a1)
• ✅ login: f-blass (dab1faf, 85b5cdd, 4bcc7c5, 9658c25)

[gururajsh]

Hi @f-blass,

Thank you for your contribution. Looks like some tests need to be addressed as part of this fix. Can you please look into it.

[f-blass]

Hi @gururajsh
thank you! Should be fixed now.

[gururajsh]

Changes look good. Can you please create PRs for main and v7 branches as well? Asking for v7, since its a fix for an issue.

[f-blass]

Hi @gururajsh
thank you. PRs for v7 and main branch are created and linked.

[gururajsh]

LGTM