Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using cflinuxfs3 #2967

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

joaopapereira
Copy link
Contributor

Description of the Change

This change will add a new opsfile to enable integration tests in edge to use cflinuxfs3.

Signed-off-by: João Pereira <joaod@vmware.com>
Copy link
Member

@moleske moleske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding cflinuxfs3? It is no longer support in the open source community. I am vaguely aware of some companies providing private cflinuxfs3 as extended support but not convinced that is something we should be testing on this open source repo. Especially as the repo is now archived and the last release was in June 2023

@joaopapereira
Copy link
Contributor Author

We are in the process of changing pools we are using to run tests for cli and to do that, we need to ensure that linuxfs-3 is present in the deployment, or else a big group of tests would have to be changed. This change is also necessary to support the current min capi version tests we will re-add.

Another point here is that we are planning on stopping support v7 around Oct, so the amount of changes that we would need to do is too big compared with just adding support for Linux-3 is too big for something that we plan on stopping supporting in a few months' time.

@moleske
Copy link
Member

moleske commented Jun 12, 2024

Definitely curious which tests need to change. Though I'm assuming these tests are only on the v7 branch.

As long as this is old contained to the v7 branch, seems reasonable.

Copy link
Member

@a-b a-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-b a-b merged commit 78b00d6 into cloudfoundry:v7 Jun 24, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants