[v8] Fix pr issues #2973
Merged
[v8] Fix pr issues #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: João Pereira <joaod@vmware.com>
Signed-off-by: João Pereira <joaod@vmware.com>
Signed-off-by: João Pereira <joaod@vmware.com>
Starting on version 1.181.0, capi will no longer report the version of the nginx server to ensure that no information is leaked. For more information check cloudfoundry/capi-release#406 Signed-off-by: João Pereira <joaod@vmware.com>
Starting on version 76.26.0 of UAA a change was made that changes the behavior more context in cloudfoundry/uaa#2545 Signed-off-by: João Pereira <joaod@vmware.com>
a-b
reviewed
Jun 20, 2024
| @@ -40,17 +36,6 @@ jobs: | |||
| runs-on: ${{ inputs.os }} | |||
| container: us-west2-docker.pkg.dev/shepherd-268822/shepherd2/concourse-resource:latest | |||
| steps: | |||
| - uses: LouisBrunner/checks-action@v2.0.0 | |||
There was a problem hiding this comment.
@joaopapereira, does the removal of this step mean that the integration tests run will no longer be reflected in the check?
There was a problem hiding this comment.
Given that the tests are now part of the unit tests workflow, there is no need to add extra check tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fix github action failing while testing PRs. We found out that when we were using workflow_run, we were always retrieving the workflow files from the main branch. The main change that is made here is to stop relying on workflow_run and to call the integration tests after the unit tests are successful.