Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Content-Type header while downloading droplets [v8] #2975

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

gururajsh
Copy link
Member

Description of the Change

Downloading a droplet from an S3 compatible storage using the command cf download-droplet fails when Content-Type header is set in the request. So, removing it the header for this command.

Why Is This PR Valuable?

Allows users to download droplet from S3 compatible storage.

Applicable Issues

NA

How Urgent Is The Change?

NA

Other Relevant Parties

NA

Fix lint target in Makefile
@gururajsh gururajsh requested a review from moleske June 21, 2024 02:50
Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@moleske moleske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks oddly similar to the other prs for this :)

Copy link
Member

@a-b a-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-b a-b merged commit 01d27c5 into cloudfoundry:v8 Jun 25, 2024
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants