Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When calling /v2/spaces/:spaceGuid/services, space-scoped services return an empty array for their service plans #821

Closed
jberney opened this issue May 11, 2017 · 3 comments

Comments

@jberney
Copy link

jberney commented May 11, 2017

Issue

When we call /v2/spaces/:spaceGuid/services, any services that are space-scoped will return an empty array in the service_plans key, even when they do have service plans.

Context

  • When calling /v2/spaces/:spaceGuid/services on the same service when it is not space-scoped, this endpoint does return the service plans as expected.
  • When calling /v2/services/:serviceGuid/service_plans on such space-scoped services, they do return their service plans.
  • Our expectation is that these service plans should also be provided for space-scoped services by the /v2/spaces/:spaceGuid/services endpoint, but they are not.

Note: we are using the parameter, inline-relations-depth=1. Here is an example call we are making:

https://apps.sys.scar.gcp.appsman.cf-app.com/proxy/api/v2/spaces/b409aae2-048b-44be-b023-0d2db3ecf684/services?results-per-page=100&inline-relations-depth=1&page=1

Steps to Reproduce

  • Deploy a space-scoped service that has one or more service plans to an org/space in a CF installation
  • Call /v2/spaces/:spaceGuid/services on the space to which the space-scoped service was deployed

Expected result

  • The service_plans key for the space-scoped service should contain an array of service plan details, that is:
  • similar to the data returned by /v2/services/:serviceGuid/service_plans for the service
  • the same as the data returned in service_plans key when the service is not space-scoped

Current result

  • The service_plans key for the space-scoped service is an empty array
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/145290403

The labels on this github issue will be updated when the story is started.

@Gerg
Copy link
Member

Gerg commented Jun 6, 2017

Hey @jberney

Thanks for submitting this issue. We were able to reproduce it as you described and are working on a fix.

Thanks,
@Gerg && @ericpromislow

Gerg added a commit that referenced this issue Jun 7, 2017
- In /v2/spaces/:guid/services

[finishes #145290403][#821]

Signed-off-by: Eric Promislow <eric.promislow@gmail.com>
@zrob
Copy link
Contributor

zrob commented Jun 13, 2017

Resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants