Don't orphan mitigate when Service Brokers return with 408 status code #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Service Instances Create * Service Bindings Create * Service Keys Create [finishes #159459070] Signed-off-by: Jen Spinney <jspinney@pivotal.io> Signed-off-by: William Martin <wmartin@pivotal.io> Signed-off-by: Luis Urraca <lurraca@pivotal.io>
|
Hey lurraca! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/159731068 The labels on this github issue will be updated when the story is started. |
lurraca
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1201
The CC no longer performs orphan mitigation if the service broker responds that the CC request timed out (HTTP code 408). This is consistent with the change to the OSBAPI spec as of OSBAPI version 2.14 (introduced in this spec PR: openservicebrokerapi/servicebroker#456).
The changes were applied to the following operations:
Service Instances Create
Service Bindings Create
Service Keys Create
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
masterbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests