Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Canary deployments #3892

Merged
merged 13 commits into from
Jul 29, 2024
Merged

Add Canary deployments #3892

merged 13 commits into from
Jul 29, 2024

Conversation

Samze
Copy link
Contributor

@Samze Samze commented Jul 18, 2024 •
edited by sethboyles
Loading

New Baras test - cloudfoundry/capi-bara-tests#101

Closes #3837

Trying it

cf push dora -i 2

# Trigger a canary deploy
deployment_guid=$(cf curl -X POST /v3/deployments -d "{ \"strategy\": \"canary\", \"relationships\": { \"app\": { \"data\": { \"guid\": [\"$(cf app dora --guid)\"] } } } }" | jq -r .guid)

# Observe that a new canary web process starts
cf apps

# Observe the deployment is in state paused
cf curl  /v3/deployments/$deployment_guid | jq .status

# Continue the deployment
cf curl -X POST /v3/deployments/$deployment_guid/actions/continue

# Observe as the canary app is rolled out and old processes are removed
watch cf apps

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

@Samze Samze marked this pull request as draft July 18, 2024 22:11
@Samze Samze changed the title Add Canary deployments as an experimental feature Add Canary deployments Jul 18, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jul 23, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

Samze and others added 12 commits July 23, 2024 23:45
@Samze @sethboyles
Initial Canary deployments implementation
fda1d35 
Co-authored-by: Sam Gunaratne <sam.gunaratne@broadcom.com>
Co-authored-by: Seth Boyles <seth.boyles@broadcom.com>
@Samze @sethboyles
Add continue link and tests
563bd95 
Co-authored-by: Sam Gunaratne <sam.gunaratne@broadcom.com>
Co-authored-by: Seth Boyles <seth.boyles@broadcom.com>
@Samze @sethboyles
Add canary api docs
ec9f2bf 
Co-authored-by: Sam Gunaratne <sam.gunaratne@broadcom.com>
Co-authored-by: Seth Boyles <seth.boyles@broadcom.com>
@Samze @sethboyles
Linting fixes
371b29a 
Co-authored-by: Sam Gunaratne <sam.gunaratne@broadcom.com>
Co-authored-by: Seth Boyles <seth.boyles@broadcom.com>
@Samze @sethboyles
Update deployment telemetry strategy logic
25862e0 
Co-authored-by: Sam Gunaratne <sam.gunaratne@broadcom.com>
Co-authored-by: Seth Boyles <seth.boyles@broadcom.com>
@Samze @sethboyles
Update deployment model states
41d8973 
Co-authored-by: Sam Gunaratne <sam.gunaratne@broadcom.com>
Co-authored-by: Seth Boyles <seth.boyles@broadcom.com>
@Samze @sethboyles
Add experimental to canary deployment docs
42a85e7 
Co-authored-by: Sam Gunaratne <sam.gunaratne@broadcom.com>
Co-authored-by: Seth Boyles <seth.boyles@broadcom.com>
@Samze @sethboyles
Add logging to when canary pauses
39fb1fc 
Co-authored-by: Sam Gunaratne <sam.gunaratne@broadcom.com>
Co-authored-by: Seth Boyles <seth.boyles@broadcom.com>
@Samze @sethboyles
Remove canary comments/todos
4fc1d7c 
Co-authored-by: Sam Gunaratne <sam.gunaratne@broadcom.com>
Co-authored-by: Seth Boyles <seth.boyles@broadcom.com>
@Samze @sethboyles
Use ACTIVE status for cancelable states in deployment
3a1fcde 
Co-authored-by: Sam Gunaratne <sam.gunaratne@broadcom.com>
Co-authored-by: Seth Boyles <seth.boyles@broadcom.com>
@Samze @sethboyles
Remove canary comments/todos
0a978fa 
Co-authored-by: Sam Gunaratne <sam.gunaratne@broadcom.com>
Co-authored-by: Seth Boyles <seth.boyles@broadcom.com>
@Samze
Add strategy to deployment audit spec
fc967d2
@sethboyles sethboyles force-pushed the canary_deployments_new branch from 0dcb80e to fc967d2 Compare July 23, 2024 23:45
@sethboyles sethboyles marked this pull request as ready for review July 24, 2024 23:46
xandroc
xandroc approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@xandroc xandroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great test coverage, this looks good
LGTM!

tcdowney
tcdowney requested changes Jul 29, 2024
View reviewed changes
Copy link
Member

@tcdowney tcdowney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, have a minor docs suggestion though.

docs/v3/source/includes/resources/deployments/_header.md Outdated Show resolved Hide resolved
@Samze @tcdowney
Improve canary documentation phrasing
bd87292 
Co-authored-by: Tim Downey <tcdowney@users.noreply.github.com>
@Samze Samze requested review from tcdowney and xandroc July 29, 2024 18:14
@Samze Samze merged commit d66f46a into main Jul 29, 2024
9 checks passed
@Samze Samze deleted the canary_deployments_new branch July 29, 2024 19:15
ari-wg-gitbot added a commit to cloudfoundry/capi-release that referenced this pull request Jul 29, 2024
@ari-wg-gitbot
Bump cloud_controller_ng
711b100 
Changes in cloud_controller_ng:

- Add Canary deployments
    PR: cloudfoundry/cloud_controller_ng#3892
    Author: Sam Gunaratne <385176+Samze@users.noreply.github.com>
    Author: Sam Gunaratne <sam.gunaratne@broadcom.com>
@xandroc xandroc mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xandroc xandroc xandroc approved these changes

@tcdowney tcdowney tcdowney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Canary Deployments Proposal
3 participants
@Samze @tcdowney @xandroc