Don't unnecessarily load all models in stack check #3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethboyles
force-pushed
the
no-load-models-in-stack-check
branch
from
95a90ed to
a7d8116
Compare
sethboyles
changed the title
* loading all models can cause issues in cases where the table for a model does not yet exist
sethboyles
force-pushed
the
no-load-models-in-stack-check
branch
from
a7d8116 to
523f1de
Compare
Samze
reviewed
Aug 28, 2024
Co-authored-by: Sam Gunaratne <385176+Samze@users.noreply.github.com>
Co-authored-by: Sam Gunaratne <385176+Samze@users.noreply.github.com>
Co-authored-by: Sam Gunaratne <385176+Samze@users.noreply.github.com>
Co-authored-by: Sam Gunaratne <385176+Samze@users.noreply.github.com>
|
@Samze do you mind giving an official GitHub Approval TM? |
Samze
approved these changes
Aug 28, 2024
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Aug 28, 2024
Changes in cloud_controller_ng:
- Don't unnecessarily load all models in stack check
PR: cloudfoundry/cloud_controller_ng#3941
Author: Seth Boyles <seth.boyles@broadcom.com>
Author: Alex Rocha <alex.rocha@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix an issue affecting the current release; we plan to refactor this further to remove any model logic at all in the future.
A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests