Issue 4092: Mark "FAILED" droplets/packages as expired #4093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* otherwise they will never be cleaned up * create package delete jobs only if there is a hash (= package has a blob)
jochenehret
force-pushed
the
issue_4092
branch
from
c87ece0 to
a14a5d5
Compare
sethboyles
approved these changes
Nov 19, 2024
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Nov 21, 2024
Changes in cloud_controller_ng:
- Issue 4092: Mark "FAILED" droplets/packages as expired
PR: cloudfoundry/cloud_controller_ng#4093
Author: Jochen Ehret <jochen.ehret@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Droplets and packages in state "FAILED" shall be marked as "EXPIRED" so that they eventually get cleaned up. For packages, delete jobs shall only be created if there is a hash (= package has a blob).
An explanation of the use cases your change solves
Prevents accumulation of old package/droplet rows in the database.
Links to any other associated PRs
Droplets without a
droplet_hashand in stateFAILEDare never cleaned up #4092I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run [CF Acceptance Tests] (https://github.com/cloudfoundry/cloud_controller_ng/blob/main/spec/README.md#cf-acceptance-tests-cats)
-> locally on a dev bbl env