Output the duration used when it is overridden #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of the CredHub server will include two new fields - duration_overridden, which indicates the server-configured minimum was used instead of the requested duration, and duration_used, which indicates the final duration used to generate / regenerate the certificate. When these fields are present, and the duration_overridden flag is true, the CLI will print out: duration_overridden_to: X with the value of the actual duration used. Co-authored-by: Preethi Varambally <pvarambally@pivotal.io> Co-authored-by: Brian Upton <bupton@vmware.com> Co-authored-by: Pablo Rodas <prodas@vmware.com>
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/179289311 The labels on this github issue will be updated when the story is started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #110
Newer versions of the CredHub server will include two new fields -
duration_overridden, which indicates the server-configured minimum was
used instead of the requested duration, and duration_used, which
indicates the final duration used to generate / regenerate the
certificate.
When these fields are present, and the duration_overridden flag is true,
the CLI will print out:
duration_overridden_to: X
with the value of the actual duration used.
Co-authored-by: Preethi Varambally pvarambally@pivotal.io
Co-authored-by: Brian Upton bupton@vmware.com
Co-authored-by: Pablo Rodas prodas@vmware.com