Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Move LastUpdated property on the LRP CR from its Spec object to the Status object #205

Closed
danail-branekov opened this issue Apr 15, 2021 · 1 comment
Milestone

Comments

@danail-branekov
Copy link
Member

danail-branekov commented Apr 15, 2021

Also, LastUpdated should be automatically set by the LRP controller on update rather than allowing users to do that via manual updates.

@danail-branekov
Copy link
Member Author

It is not quite clear what this property is expected to be used for in the K8S world.
In the VM world, CC would send the value upon LRP updates (i.e. when CC calls the Update endpoint). We suspect that this is needed to verify whether the version of the LRP in the CC database matches the one that is actually running.

In K8S world this consistency is ensured by controllers so we do not need a special field. It feels like we could just get rid of the field in our custom resources but let's talk about it on standup.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants