bump ginkgo to v2 and lager to v3 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Yang <ruiya@vmware.com>
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
|
|
|
@xtremerui I had to revert this PR since the effect of bumping lager to v3 is quite significant and requires other dependent libraries (outside of our control) to also get bumped. You can follow the cloudfoundry/lager#47. I think the best resolution would be to remove the tagged versions and rely on changes from main branch. |
|
Thank you for the pointer @winkingturtle-vmw we will keep an eye on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason of this PR is Concourse encountered an issue when trying to upgrade to ginkgo v2.
I then figured out it was the cloudfoundry lager lib that caused the problem. Luckily,
lagerhas a v3 version already that supports ginkgo v2. After bumping lager to v3 in Concourse, the ginkgo issue is resolved but then we have compilation error when garden is still using lager v2 here.In order to bump lager to v3 for garden, ginkgo has to be bumped to v2 otherwise the same ginkgo issue will happen again here since garden is using ginkgo v1 when lager v3 is using ginkgo v2.
So in this PR, changes are:
go mod tidyrango mod vendorranconfig.GinkgoConfig.ParallelNodeis replaced byGinkgoParallelProcess(), refer to here