Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Delete Service Credential Binding does not return job GUID #395

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

Dray56
Copy link
Contributor

@Dray56 Dray56 commented Mar 21, 2024

fixes #394

@sneal
Copy link
Contributor

sneal commented Mar 21, 2024

Thanks for the contribution. It looks like the endpoint can return a jobID or nothing depending on whether a user provided service or a managed service instance binding is deleted. Can you add an additional test to cover the user provided use case that returns 204 No Content?

…foundry-community#394

Signed-off-by: Debaditya Ray <debaditya.ray@sap.com>
@Dray56
Copy link
Contributor Author

Dray56 commented Mar 22, 2024

Hi @sneal ,
Is it fine now?

@sneal
Copy link
Contributor

sneal commented Mar 25, 2024

Thanks for adding a user provided test case.

@sneal sneal merged commit c04a32f into cloudfoundry:main Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete Service Credential Binding does not return job GUID
3 participants