Fix segmentation fault on 32-bit ARM #22
Conversation
writeIndex is written to atomically, which means it must be 64-bit aligned on 32-bit 386 and ARM platforms. When the buffer slice is above it, it becomes unaligned and segfaults on the call to atomic.AddUint64(). See golang/go#23345
|
Hey kdrag0n! Thanks for submitting this pull request! All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate), and send to: contributors@cloudfoundry.org. When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization. If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions. Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/158995648 The labels on this github issue will be updated when the story is started. |
|
Merging as per this documentation. |
Fix segmentation fault on 32-bit ARM by moving atomic uint64 to be the first field in ManyToOne.
writeIndex is written to atomically, which means it must be 64-bit aligned on 32-bit 386 and ARM platforms. When the buffer slice is above it, it becomes unaligned and segfaults on the call to atomic.AddUint64().
See golang/go#23345