Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for FreeBSD #63

Merged
merged 15 commits into from
Jan 30, 2023
Merged

Support for FreeBSD #63

merged 15 commits into from
Jan 30, 2023

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jan 16, 2023

FreeBSD support, tested on 13.1-RELEASE

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 16, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dveeden / name: Daniël van Eeden (83222d0)

@dveeden dveeden marked this pull request as ready for review January 16, 2023 21:57
@dveeden dveeden mentioned this pull request Jan 16, 2023
@rkoster rkoster requested review from a team, ragaskar and lnguyen and removed request for a team January 19, 2023 09:33
Copy link
Member

@lnguyen lnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, curious are you using this lib for your own apps?

@dveeden
Copy link
Contributor Author

dveeden commented Jan 24, 2023

LGTM, curious are you using this lib for your own apps?

We started to use this in https://github.com/pingcap/tidb

This is where it's used:
https://github.com/pingcap/tidb/blob/1e0956d5ba41182e603295e02ae8f767d62979e4/util/cpu/cpu.go#L108

I'm using FreeBSD to do some development, while FreeBSD isn't a officially supported platform. After gosigar was added I wasn't able to build TiDB anymore on FreeBSD.

@beyhan beyhan requested review from a team and removed request for a team and ragaskar January 26, 2023 15:37
@beyhan beyhan requested a review from danielfor January 26, 2023 15:37
@ystros ystros merged commit d64f945 into cloudfoundry:master Jan 30, 2023
@ystros
Copy link
Contributor

ystros commented Jan 30, 2023

Thanks @dveeden !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants