You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a Operator I want predictable and consistent log format So that I can use tools to search and organize logs
Acceptance Criteria
GIVEN a Korifi deployment WHEN Ikubectl logs -n korifi-controllers-system korifi-controllers-controller-manager-xxxxxxxxxx-xxxxx manager THEN I see that the results are consistently formatted in json following this proposal
Some logging appears to come from the k8s code, e.g.
I0603 20:05:55.339392 1 request.go:601] Waited for 1.040934921s due to client-side throttling, not priority and fairness, request: GET:https://10.96.0.1:443/apis/acme.cert-manager.io/v1?timeout=32s
I0603 20:05:25.656018 1 leaderelection.go:248] attempting to acquire leader lease korifi-controllers-system/13c200ec.cloudfoundry.org...
This logging is in a different format from the other log lines from the same executable. We may have some work to do in order to make sure we have loggers consistently plumbed through the layers in our code.
The text was updated successfully, but these errors were encountered:
Some logging appears to come from the k8s code, e.g.
I0603 20:05:55.339392 1 request.go:601] Waited for 1.040934921s due to client-side throttling, not priority and fairness, request: GET:https://10.96.0.1:443/apis/acme.cert-manager.io/v1?timeout=32s
I0603 20:05:25.656018 1 leaderelection.go:248] attempting to acquire leader lease korifi-controllers-system/13c200ec.cloudfoundry.org...
Based on an issue we saw in controller runtime (1420) we may not be able to control the logger used by client-go in the leaderelection package, so those logs will remain controlled by the default klog implementation.
Edit: It looks like y'all managed to set the klog logger in a related story to defer to our logging without having to separately configure its format.
Blockers/Dependencies
Background
As a Operator
I want predictable and consistent log format
So that I can use tools to search and organize logs
Acceptance Criteria
GIVEN a Korifi deployment
WHEN I
kubectl logs -n korifi-controllers-system korifi-controllers-controller-manager-xxxxxxxxxx-xxxxx manager
THEN I see that the results are consistently formatted in json following this proposal
Dev Notes
See implementation notes in the proposal for suggestions
Some logging appears to come from the k8s code, e.g.
This logging is in a different format from the other log lines from the same executable. We may have some work to do in order to make sure we have loggers consistently plumbed through the layers in our code.
The text was updated successfully, but these errors were encountered: