fix/adapt scripts to work on mac #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#2108
What is this change about?
I ran the
deploy-on-kind.shon my Mac and ran into a couple of issues that this PR adresses:LC_ALL=en_US.UTF-8in the script fixes this.registry_configurationis an empty array, I get a "unbound variable" so I added a default empty value. As array elements are interpreted as if in single quotes,helmthinks it is getting one argument too many. Removing the double quotes fixes this.[[ -v VAR_NAME ]]syntax. Comparing via== "true"should work on both newer and older machines.Does this PR introduce a breaking change?
no