Do not return forbidden error on get domain failure #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning a forbidden error upon any failure when getting the CFDomain from the repository is simply wrong, especially in situations where handlers are masking forbidden errors as not found. Potentially this should give use more information to ivestigate the flake below should it occur again https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/16159 Co-authored-by: Danail Branekov <danailster@gmail.com>
georgethebeatle
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
No
What is this change about?
Returning a forbidden error upon any failure when getting the CFDomain
from the repository is simply wrong, especially in situations where
handlers are masking forbidden errors as not found.
Potentially this should give use more information to ivestigate the
flake below should it occur again
https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-periodic/builds/16159
Does this PR introduce a breaking change?
No
Tag your pair, your PM, and/or team
@georgethebeatle