Support broker name filter when listing service plans #3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The broker controller sets the broker name under the
`korifiv1alpha1.RelServiceBrokerNameLabel` label when reconciling
broker catalog. This is safe as upon a broker rename the controller
would reconcile its catalog again and would ammend plans/offering
labels
* The plan repository filters plans by broker name whenever the broker
names filter is specified
* While being here:
- The constant `RelServiceBrokerLabel` has been renamed to
`RelServiceBrokerGUIDLabel` to make it explicit that this is the
broker guid
- The constant `RelServiceOfferingLabel has been renamed to
`RelServiceOfferingGUIDLabel` to make it explicit that this is the
offering guid
- The value of the `RelServiceBrokerGUIDLabel` and
`RelServiceOfferingGUIDLabel` constants has the `-guid` suffix added
in order to be more explicit
fixes #3420
danail-branekov
force-pushed
the
issue/3420-filter-plans-by-broker-name
branch
from
ac0f13e
to
f8bab10
Compare
georgethebeatle
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3420
What is this change about?
korifiv1alpha1.RelServiceBrokerNameLabellabel when reconcilingbroker catalog. This is safe as upon a broker rename the controller
would reconcile its catalog again and would ammend plans/offering
labels
names filter is specified
RelServiceBrokerLabelhas been renamed toRelServiceBrokerGUIDLabelto make it explicit that this is thebroker guid
RelServiceOfferingLabel has been renamed toRelServiceOfferingGUIDLabel` to make it explicit that this is theoffering guid
RelServiceBrokerGUIDLabelandRelServiceOfferingGUIDLabelconstants has the-guidsuffix addedin order to be more explicit
Tag your pair, your PM, and/or team
@georgethebeatle