Update to ginkgo v2 and remove deprecated ginkgo reporter #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aminjam any chance of getting this in ? |
ctlong
suggested changes
Sep 27, 2022
ctlong
changed the title
ctlong
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
our project the cf app-autoscaler-release needs to move to ginkgo v2
Unfortunately the way it is used means that v1 and v2 can not exist in the same dependency tree.
This means that the test module in this project needs to be dealt with ... the easiest thing is to remove
This would be a breaking change.
Its likely if there is no reponse we will move to a newer logging library.