Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cf create|update-service-broker to register the service #972

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

davewalter
Copy link
Member

@davewalter davewalter commented Jun 12, 2024

  • Set the CF_BROKER_PASSWORD env var to eliminate the password from the commands being run.
  • This eliminates code that attempts to parse the JSON output from the /v2/service_brokers CF API endpoint with grep and cut, which will no longer work as of CAPI release v1.183.0 due to a change in formatting.
  • Also remove support for deprecated CF CLI packages.
  • TAS only colocates the cf-cli-8-linux package onto the instances that are used to run errands.

- Set the CF_BROKER_PASSWORD env var to eliminate the password from the
  commands being run.
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@@ -2,8 +2,6 @@
set -euo pipefail
set -x

PATH="/var/vcap/packages/cf-cli-6-linux/bin:${PATH}"
PATH="/var/vcap/packages/cf-cli-7-linux/bin:${PATH}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davewalter It looks cf-cli-7 is still supported. Our CI is failing because that's what it was using. Can we only remove cf-cli-6 and keep the other two for now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've restored the cf-cli-7-linux package addition to the PATH so it should be able to run now.

@winkingturtle-vmw
Copy link
Contributor

@davewalter After deploying the latest changes, it looks cf v7 doesn't support CF_BROKER_PASSWORD style of input. I have instead made a PR for cf-deployment (cloudfoundry/cf-deployment#1186) to bump from v7 to v8. Let's remove the last commit to only support v8.

- CF-Deployment and TAS only colocate the cf-cli-8-linux package
  onto the instances that are used to run errands.
@tas-runtime-bot tas-runtime-bot merged commit 909170c into cloudfoundry:master Jun 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants