supply: remove pre-installing mercurial #576
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited Fri 8/26 with more details
What does this change address?
a remote url via a VCS like
hg
, themercurial
package should bepre-installed. Pip documentation just states that it requires a working
executable to be available, which already exists on the stack.
fixtures/mercurial
is built by this branch's buildpack,we can see in the log python-hglib (which was the package referred to in
the testdata by hg clone url) is installed.
pip install mercurial
(link)came into this buildpack from the original heroku buildpack fork.
Heroku has since removed it. See Remove redundant Mercurial install step heroku/heroku-buildpack-python#1111
What does this change NOT address?
mercurial
present inthe
requirements.txt
fails with the error pointing to a non-existent include path toPython.h
even after include location is set via CFLAGS in 028a7b6.See CI log. The timing of this failure appearing in CI suggests that it's related to the
package using the new setuptools version as a transitive dependency. See python3.8.12 - fatal error: Python.h: No such file or directory #574
This has to be separately investigated.