Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multiple region support for quota #1263

Merged
merged 11 commits into from
Mar 12, 2021

Conversation

anujbansal16
Copy link
Contributor

@anujbansal16 anujbansal16 commented Feb 25, 2021

Feature: HCPCFS-2886

This PR enhance the broker to support multiple regions. Enhancements are listed below:

  • Extending the broker routes to support the region as a url parameter.
    Example: https://example-broker.com/region/eu10/v2/...
  • Based on the region provided as a part of url, we extract the particular credential for quota validations.
  • Tagging each sfserviceinstance based the the region so that it could be determined which region the service instance is from.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/177090005

The labels on this github issue will be updated when the story is started.

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #1263 (32fd23a) into master (ed609f0) will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1263      +/-   ##
==========================================
+ Coverage   71.52%   71.65%   +0.13%     
==========================================
  Files          44       44              
  Lines        3817     3817              
==========================================
+ Hits         2730     2735       +5     
+ Misses        769      765       -4     
+ Partials      318      317       -1     

@coveralls
Copy link

coveralls commented Feb 25, 2021

Pull Request Test Coverage Report for Build 5200

  • 40 of 43 (93.02%) changed or added relevant lines in 11 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 89.153%

Changes Missing Coverage Covered Lines Changed/Added Lines %
broker/applications/osb-broker/src/api-controllers/ServiceBrokerApiController.js 5 6 83.33%
broker/applications/osb-broker/src/api-controllers/middleware/index.js 1 2 50.0%
broker/data-access-layer/quota/src/k8s-platform-quota-manager/K8SPlatformQuotaManager.js 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
broker/data-access-layer/quota/src/k8s-platform-quota-manager/K8SPlatformQuotaManager.js 1 54.55%
Totals Coverage Status
Change from base Build 5174: 0.004%
Covered Lines: 9446
Relevant Lines: 10224

💛 - Coveralls

Copy link
Contributor

@jayeshjk jayeshjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anujbansal16 anujbansal16 merged commit b55c27a into cloudfoundry:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants