Skip to content

Commit

Permalink
Fix terminate instance UX (#1211)
Browse files Browse the repository at this point in the history
- Bug - Untranslated string shown in terminate instance success notification
- Bug - Terminate modal shows failure after succesfully terminating (exception during client data refresh)
  • Loading branch information
richard-cox authored and Irfan Habib committed Aug 4, 2017
1 parent 6c14ec9 commit d96eb1b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,8 @@
}
];
vm.scheduledUpdate = undefined;
// Used in summary.module.js
vm.update = update;
vm.autoUpdate = {
update: update,
interval: UPDATE_INTERVAL,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@
return vm.model.terminateRunningAppInstanceAtGivenIndex(vm.cnsiGuid, vm.id, instanceIndex)
.then(function () {
appNotificationsService.notify('success',
$translate.instant('app.app-info.terminate-instance.terminate.success', { index: instanceIndex }));
$translate.instant('app.app-info.terminate-instance.success', { index: instanceIndex }));
update();
});
}
Expand Down

0 comments on commit d96eb1b

Please sign in to comment.